Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding some info for getting multiple compose running #3584

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 27, 2024

Description

As the title

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 27, 2024 10:16
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 27, 2024 10:16
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 27, 2024
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) labels Nov 27, 2024
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (93f9906) to head (c513da7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3584      +/-   ##
==========================================
- Coverage   86.98%   86.97%   -0.01%     
==========================================
  Files         187      187              
  Lines       14623    14623              
==========================================
- Hits        12720    12719       -1     
- Misses       1903     1904       +1     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 28, 2024

I'm not waiting for the CICD since this is not check by it.

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Nov 28, 2024
@germa89 germa89 merged commit 4243345 into main Nov 28, 2024
28 of 29 checks passed
@germa89 germa89 deleted the ci--improve-devcontainer-configuration branch November 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants