Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect MAPDL console output to a file #3596

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 29, 2024

Description

As the title.

Now you can do:

from ansys.mapdl.core import launch_mapdl

mapdl = launch_mapdl(mapdl_output="apdl.out")
# create a file with the console output
assert os.path.exists("apdl.out")
with open("apdl.out", "r") as fid:
    assert "START GRPC SERVER" in fid.read()

Issue linked

Close #3595

Checklist

@germa89 germa89 requested a review from a team as a code owner November 29, 2024 18:51
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 29, 2024 18:51
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 29, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (1473bdd) to head (cf67a6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   86.97%   86.97%   -0.01%     
==========================================
  Files         187      187              
  Lines       14630    14643      +13     
==========================================
+ Hits        12725    12736      +11     
- Misses       1905     1907       +2     

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4913f89 into main Dec 13, 2024
45 of 47 checks passed
@germa89 germa89 deleted the feat/piping-MAPDL-output-to-a-given-file branch December 13, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAPDL redirecting console output to a file
2 participants