Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "Merge branches 'feat/piping-MAPDL-output-to-a-given-file', 'main' and 'main' of https://github.com/ansys/pymapdl" #3607

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 9, 2024

Description

As the title, this reverts commit a97fb6c, reversing
changes made to 6853571.

For some reason, the ruleset for the repo allowed me to push to main, which is sooooo bad.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner December 9, 2024 17:49
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Dec 9, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Dec 9, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 self-assigned this Dec 9, 2024
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit afad43e into main Dec 9, 2024
38 of 44 checks passed
@germa89 germa89 deleted the revert/wrong-push branch December 9, 2024 17:59
germa89 added a commit that referenced this pull request Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (6853571) to head (259cc71).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
- Coverage   87.02%   86.97%   -0.05%     
==========================================
  Files         187      187              
  Lines       14623    14623              
==========================================
- Hits        12725    12719       -6     
- Misses       1898     1904       +6     

germa89 added a commit that referenced this pull request Dec 13, 2024
* tests: removing redundant test

* chore: adding changelog file 3596.miscellaneous.md [dependabot-skip]

* revert: "revert: "Merge branches 'feat/piping-MAPDL-output-to-a-given-file', 'main' and 'main' of https://github.com/ansys/pymapdl" (#3607)"

This reverts commit afad43e.

* fix: tests

* fix: running test only on local

* test: adding more tests

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
germa89 added a commit that referenced this pull request Jan 7, 2025
* ci: adding timeout to each test

* chore: adding changelog file 3577.dependencies.md [dependabot-skip]

* test: avoid checking command output

* test: avoid checking command output

* fix: unpack

* feat: disabling subscription to channel

* fix: components typo

* chore: adding changelog file 3577.documentation.md [dependabot-skip]

* feat: avoid checking on not set channel

* ci: automate logging when testing

* fix: reading nset when no RST is generated

* fix: detecting comments as parameters sets when they have =.

* fix: avoid fail on reading rst file

* feat: setting verbosity when debug env var

* feat: using non-interactive for using iterable in XSEL commands

* fix: running post.__repr__ as post1

* feat: logging non_interactive in MAPDL logging and APDL logging

* fix: post_processing repr

* test: post string

* fix: test

* feat: showing a warning when rebooting MAPDL.

* tests: skip some test Temporary

* fix: initial channel state

* fix: removing APDL comment so it does not interfere on the last_respone

* fix: database tests

* fix: path test

* feat: stripping spaces from the command output

* fix: checking pids when there is no cleanup file.

* fix: make sure we are properly comparing paths when MAPDL is also installed on a machine.

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* fix: small fixes in database tests

* fix: skip testing on windows for the moment

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* fix: precommit

* fix: xpl not loading full file

* refactor: moving xpl tests to a class

* feat: adding apdl output

* tests: removing redundant test

* chore: merge fix/avoid-error-when-retriving-routine

* chore: adding changelog file 3596.miscellaneous.md [dependabot-skip]

* revert: "revert: "Merge branches 'feat/piping-MAPDL-output-to-a-given-file', 'main' and 'main' of https://github.com/ansys/pymapdl" (#3607)"

This reverts commit afad43e.

* chore: adding changelog file 3577.dependencies.md [dependabot-skip]

* refactor: reorg allowed arguments order

* fix: removing `file` call.

* feat: apply suggestions from code review

* feat: apply suggestions from code review

* chore: adding changelog file 3577.added.md [dependabot-skip]

* fix: removing left behind code

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: gayuso <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants