-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing components when too many #3662
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3662 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 187 187
Lines 14694 14694
=======================================
Hits 12800 12800
Misses 1894 1894 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot really comment on whether the change fixes this problem in general, but I did successfully test it against the PyACP example which was failing before.
See this CI run: https://github.com/ansys/pyacp/actions/runs/12805394256/job/35701717093?pr=764
We are never certain our code fix anything general... so #InUnitTestingWeTrust
|
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
As the title.
Issue linked
Close #3652
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)