Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing components when too many #3662

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 14, 2025

Description

As the title.

Issue linked

Close #3652

Checklist

@germa89 germa89 requested a review from a team as a code owner January 14, 2025 19:45
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 14, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (86e535c) to head (74c6c67).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3662   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         187      187           
  Lines       14694    14694           
=======================================
  Hits        12800    12800           
  Misses       1894     1894           

@germa89 germa89 requested a review from greschd January 15, 2025 10:23
Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really comment on whether the change fixes this problem in general, but I did successfully test it against the PyACP example which was failing before.

See this CI run: https://github.com/ansys/pyacp/actions/runs/12805394256/job/35701717093?pr=764

@germa89
Copy link
Collaborator Author

germa89 commented Jan 16, 2025

I cannot really comment on whether the change fixes this problem in general, but I did successfully test it against the PyACP example which was failing before.

See this CI run: https://github.com/ansys/pyacp/actions/runs/12805394256/job/35701717093?pr=764

We are never certain our code fix anything general... so #InUnitTestingWeTrust

GitHub
Python Client for Ansys Composite PrepPost. Contribute to ansys/pyacp development by creating an account on GitHub.

@germa89 germa89 enabled auto-merge (squash) January 16, 2025 10:48
@germa89
Copy link
Collaborator Author

germa89 commented Jan 17, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 0f1e0ec into main Jan 17, 2025
65 checks passed
@germa89 germa89 deleted the fix/wrong-parsing-when-too-many-components branch January 17, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing components when there are many
3 participants