Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid com logging if not in debug mode #3665

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 14, 2025

Description

As the title.

Issue linked

Close #3655

Checklist

@germa89 germa89 requested a review from a team as a code owner January 14, 2025 21:18
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 14, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (86e535c) to head (06edbe0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   87.11%   87.12%   +0.01%     
==========================================
  Files         187      187              
  Lines       14694    14695       +1     
==========================================
+ Hits        12800    12803       +3     
+ Misses       1894     1892       -2     

@germa89 germa89 requested a review from koubaa January 15, 2025 10:22
@germa89 germa89 requested a review from koubaa January 16, 2025 10:19
def test_comment_on_debug_mode(mapdl, cleared):
loglevel = mapdl.logger.logger.level

mapdl.logger.logger.level = 40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, can use the logging names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running mapdl.parameters leads to extra console output
3 participants