-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid com logging if not in debug mode #3665
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
+ Coverage 87.11% 87.12% +0.01%
==========================================
Files 187 187
Lines 14694 14695 +1
==========================================
+ Hits 12800 12803 +3
+ Misses 1894 1892 -2 |
…ing-on-non-debug-mode
…github.com/ansys/pymapdl into fix/avoid-logging-on-non-debug-mode
def test_comment_on_debug_mode(mapdl, cleared): | ||
loglevel = mapdl.logger.logger.level | ||
|
||
mapdl.logger.logger.level = 40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, can use the logging names
Description
As the title.
Issue linked
Close #3655
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)