-
Notifications
You must be signed in to change notification settings - Fork 135
build: add shellcheck hook #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideIntroduces shellcheck linting for bash scripts by adding a shellcheck hook to the pre-commit configuration. Flow diagram for shellcheck integration in pre-commit workflowflowchart TD
A[Developer modifies bash script] --> B[Runs pre-commit]
B --> C{Is shellcheck hook enabled?}
C -- Yes --> D[Shellcheck lints bash scripts]
D --> E{Linting passed?}
E -- Yes --> F[Commit proceeds]
E -- No --> G[Show shellcheck errors]
G --> H[Fix errors and retry]
C -- No --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…sys/pymapdl into ci/adding-bash-checker
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4026 +/- ##
==========================================
- Coverage 89.12% 89.11% -0.01%
==========================================
Files 187 187
Lines 14970 14970
==========================================
- Hits 13342 13341 -1
- Misses 1628 1629 +1 🚀 New features to boost your workflow:
|
Description
As the title. To check bash scripts.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
CI: