feat: add conversations's menu trigger #630

kimteayon · 2025-03-20T11:17:33Z

中文版模板 / Chinese template

🤔 This is a ...

🆕 New feature

add conversations's menu trigger

🔗 Related Issues

#592

💡 Background and Solution

#618

📝 Change Log

Language	Changelog
🇺🇸 English	New custom triggers for operations added to the conversations component
🇨🇳 Chinese	conversations组件新增操作自定义触发器

coderabbitai · 2025-03-20T11:17:40Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-20T11:17:45Z

petercat-assistant · 2025-03-20T11:17:48Z

Walkthrough

This pull request introduces a new feature to the conversations component by adding customizable menu triggers. The changes allow developers to define custom triggers for menu operations within the component, enhancing flexibility and user interaction.

Changes

Files	Summary
components/conversations/Item.tsx	Added logic for customizable menu triggers using `useCallback` to handle trigger nodes.
components/conversations/tests/snapshots/demo-extend.test.ts.snap	Updated snapshot tests for extended demo.
components/conversations/tests/snapshots/demo.test.ts.snap	Updated snapshot tests for demo.
components/conversations/demo/with-menu-trigger.md	Added documentation for custom menu entry in both Chinese and English.
components/conversations/demo/with-menu-trigger.tsx	Added a new demo showcasing the custom menu trigger feature.
components/conversations/index.en-US.md	Updated documentation to include custom operations demo.
components/conversations/index.zh-CN.md	Updated Chinese documentation to include custom operations demo.

components/conversations/Item.tsx

codecov · 2025-03-20T11:18:44Z

Bundle Report

Bundle size has no change ✅

codecov · 2025-03-21T05:59:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (e3774b9) to head (0449073).

Additional details and impacted files

@@             Coverage Diff             @@
##           feature     #630      +/-   ##
===========================================
+ Coverage    91.81%   91.85%   +0.03%     
===========================================
  Files           67       67              
  Lines         1466     1473       +7     
  Branches       388      390       +2     
===========================================
+ Hits          1346     1353       +7     
  Misses         120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

components/conversations/Item.tsx

components/conversations/__tests__/index.test.tsx

components/conversations/demo/with-menu-trigger.md

afc163 · 2025-03-24T04:35:45Z

components/conversations/demo/with-menu-trigger.tsx

+      },
+    ],
+    onClick: (menuInfo) => {
+      menuInfo.domEvent.stopPropagation();


这个 stopPropagation 是必须的么？

嗯是的这个是很多issue 提的问题组件本身设计上是不容易去修改的这样写可以提供一个demo

原因是啥？

components/conversations/demo/with-menu-trigger.tsx

components/conversations/index.en-US.md

components/conversations/interface.ts

components/conversations/demo/with-menu-trigger.tsx

components/conversations/index.tsx

components/conversations/demo/with-menu-trigger.tsx

components/conversations/Item.tsx

kimteayon added 3 commits March 20, 2025 18:57

feat: add conversations's menu trigger

ba3e519

feat: add conversations's menu trigger

7ae0b18

feat: add conversations's menu trigger

024923c

petercat-assistant bot reviewed Mar 20, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

kimteayon added 3 commits March 20, 2025 19:21

feat: add conversations's menu trigger

fa45308

feat: add conversations's menu trigger

9e11002

feat: add conversations's menu trigger

1c48511

test: add conversations's menu trigger

ac236cb

kimteayon requested review from afc163 and pokerface9830 March 21, 2025 14:01

afc163 requested a review from zombieJ March 24, 2025 04:31

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/__tests__/index.test.tsx Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.md Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.md Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/index.en-US.md Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/interface.ts Outdated Show resolved Hide resolved

kimteayon added 2 commits March 24, 2025 15:31

feat: add conversations's menu trigger

39f3f63

feat: add conversations's menu trigger

a073bc1

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/index.tsx Outdated Show resolved Hide resolved

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/demo/with-menu-trigger.tsx Outdated Show resolved Hide resolved

kimteayon added 3 commits March 24, 2025 16:00

test: add conversations's menu trigger

d34e0f6

test: add conversations's menu trigger

1a18e32

test: add conversations's menu trigger

f965efe

kimteayon requested a review from afc163 March 24, 2025 08:19

docs: add conversations's menu trigger

d92e748

afc163 reviewed Mar 24, 2025

View reviewed changes

components/conversations/Item.tsx Outdated Show resolved Hide resolved

kimteayon added 2 commits March 24, 2025 20:59

feat: add conversations's menu trigger

4be95cd

test: add conversations's menu trigger

d20e53b

kimteayon requested a review from afc163 March 24, 2025 13:12

kimteayon added 2 commits March 24, 2025 21:34

test: add conversations's menu trigger

1009a2f

test: conversations's menu trigger

0449073

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add conversations's menu trigger #630

feat: add conversations's menu trigger #630

kimteayon commented Mar 20, 2025

coderabbitai bot commented Mar 20, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Mar 20, 2025 •

edited

Loading

petercat-assistant bot commented Mar 20, 2025

codecov bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 21, 2025 •

edited

Loading

afc163 Mar 24, 2025

kimteayon Mar 24, 2025

afc163 Mar 24, 2025

feat: add conversations's menu trigger #630

Are you sure you want to change the base?

feat: add conversations's menu trigger #630

Conversation

kimteayon commented Mar 20, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

coderabbitai bot commented Mar 20, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Mar 20, 2025 • edited Loading

petercat-assistant bot commented Mar 20, 2025

Walkthrough

Changes

codecov bot commented Mar 20, 2025 • edited Loading

Bundle Report

codecov bot commented Mar 21, 2025 • edited Loading

Codecov Report

afc163 Mar 24, 2025

Choose a reason for hiding this comment

kimteayon Mar 24, 2025

Choose a reason for hiding this comment

afc163 Mar 24, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Mar 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading

codecov bot commented Mar 21, 2025 •

edited

Loading