remove redundant timeouts in Gossip #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpyattaev
changed the title
alexpyattaev
force-pushed
the
remove_timeouts_in_gossip_consume
branch
from
dc83d6b to
8ed1aaf
Compare
gregcusack
approved these changes
Mar 6, 2025
| @@ -2127,7 +2126,7 @@ impl ClusterInfo { | |||
| let mut dropped_packets_counts = [0u64; 7]; | |||
| let mut num_packets = 0; | |||
| for packet_batch in receiver | |||
| .recv_timeout(RECV_TIMEOUT) | |||
| .recv() | |||
There was a problem hiding this comment.
this just blocks forever until we receive a message right? think this should be ok since we don't need to do anything else except wait for messages here. plus we should constantly be getting messages
There was a problem hiding this comment.
it blocks until message or disconnect from sender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unnecessary timeouts in Gossip Consume code. Similar timeouts were previously removed from turbine retransmit stage in #4335
Summary of Changes
Partially addresses
#5034
Tested on MNB validator DmCowGH9DUHYCetfGaWzPzYCi455yDxewcycdyWuPLjx at 2025/03/03 14:50-16:00 UTC
Normal operation of gossip is not affected.
Restarts/shutdowns work ok.