Migrate Edge calls for Worker to FastAPI part 4 - Cleanup #44434
+2,015
−830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… over existing setups
jscheffl
added
area:providers
AIP-69
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- docs/spelling_wordlist.txt: Language not supported
- providers/src/airflow/providers/edge/CHANGELOG.rst: Language not supported
- providers/src/airflow/providers/edge/worker_api/routes/_v2_routes.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/auth.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/datamodels.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/app.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/routes/rpc_api.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/routes/logs.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/routes/jobs.py: Evaluated as low risk
- providers/src/airflow/providers/edge/init.py: Evaluated as low risk
- providers/src/airflow/providers/edge/worker_api/routes/_v2_compat.py: Evaluated as low risk
- providers/src/airflow/providers/edge/executors/edge_executor.py: Evaluated as low risk
- providers/src/airflow/providers/edge/models/edge_logs.py: Evaluated as low risk
- providers/src/airflow/providers/edge/models/edge_job.py: Evaluated as low risk
- providers/src/airflow/providers/edge/cli/edge_command.py: Evaluated as low risk
| return datetime.fromisoformat(result) | ||
|
|
||
|
|
||
| def worker_set_state( |
There was a problem hiding this comment.
The docstring for the worker_set_state function is misleading. It should be updated to reflect that this function updates the worker state, not registers it.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #44311, #44330 and #44433 this PR is a cleanup and removes the old Internal API extensions.
For review: Only the last commit is relevant, the other 9 are from referenced base PRs