Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webserver parameters: max_form_parts, max_form_memory_size #45749

Merged

Conversation

moiseenkov
Copy link
Contributor

@moiseenkov moiseenkov commented Jan 17, 2025

The problem resolved in this PR:

  • max_form_parts (https://flask.palletsprojects.com/en/stable/api/#flask.Request.max_form_parts) is not configurable in Airflow web server (1000 is the default value).
  • max_form_parts is relevant for a "role edit" form in Airflow UI.
  • Size of the role (number of permissions) contributes to the number of form parts in POST request generated by Airflow UI.
  • There are real-life cases (roles with hundreds of permissions) where max_form_parts is exceeded (error 413) and blocks updating roles through the Airflow UI.

In order to overcome this limitation, two more webserver config options were introduced:

  • [webserver]max_form_parts = 1000
  • [webserver]max_form_memory_size = 500000

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 17, 2025
@moiseenkov moiseenkov closed this Jan 17, 2025
@moiseenkov moiseenkov reopened this Jan 20, 2025
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jan 20, 2025

Should this be considered a bug fix ? (for big installs).

Asking because no new features will be release for airflow 2. And that's not needed for airflow 3.

airflow/config_templates/config.yml Show resolved Hide resolved
@pierrejeambrun pierrejeambrun added the backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch label Jan 29, 2025
@pierrejeambrun pierrejeambrun merged commit bb2aaef into apache:main Jan 29, 2025
87 of 88 checks passed
@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Jan 29, 2025
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Copy link

Backport successfully created: v2-10-test

Status Branch Result
v2-10-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jan 29, 2025
github-actions bot pushed a commit to astronomer/airflow that referenced this pull request Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
utkarsharma2 pushed a commit that referenced this pull request Jan 30, 2025
dabla pushed a commit to dabla/airflow that referenced this pull request Jan 30, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants