Connect Trigger UI Conf with the flexible form #45790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
jscheffl
reviewed
Jan 20, 2025
shubhamraj-git
requested review from
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Pretty cool in the current state. Did a second pass review and some testing.
Let me know if I shall contribute fixes to your branch, I catched the idea now and before a lot of detail ping-pong I can help as well (knowing all the dirty legacy). Anyway no big problems besides the comments.
bbovenzi
reviewed
Jan 23, 2025
jscheffl
reviewed
Jan 25, 2025
jscheffl
reviewed
Jan 25, 2025
Co-authored-by: Jens Scheffler <[email protected]>
Co-authored-by: Jens Scheffler <[email protected]>
jscheffl
approved these changes
Jan 25, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* centralised setup * refactor * remove param pass * remove reset * date time fix * refactor * accordion css * remove console error * copy params * reviews * css alert * fix * reviews regarding setting null * refactor * Empty Objects sets to Null Co-authored-by: Jens Scheffler <[email protected]> * Fix Date and time Co-authored-by: Jens Scheffler <[email protected]> --------- Co-authored-by: Jens Scheffler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of #45270 by @jscheffl
Future Work (Not decided, might need discussion):
closes: #22408 #44858
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.