Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create operators for working with Clusters for GCP Apache Kafka #45795

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

MaksYermak
Copy link
Contributor

In this PR I have created operators for working with Clusters for GCP Managed Service for Apache Kafka


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Jan 20, 2025
@VladaZakharova
Copy link
Contributor

hi @potiuk ! Can you please check changes from this PR? :)

@MaksYermak MaksYermak force-pushed the apache-kafka-clusters branch from 03d48d3 to 57c8744 Compare January 27, 2025 15:36
@MaksYermak
Copy link
Contributor Author

@eladkal I have updated the naming for hook and operators. Could you please check PR one more time?

@VladaZakharova
Copy link
Contributor

Hi @eladkal ! Can you please check changes here? Thanks :)

@eladkal
Copy link
Contributor

eladkal commented Feb 4, 2025

Hi @eladkal ! Can you please check changes here? Thanks :)

sorry won't get to it in the next 1-2 weeks. Maybe someone else can review

@VladaZakharova
Copy link
Contributor

Hi @eladkal ! Can you please check changes here? Thanks :)

sorry won't get to it in the next 1-2 weeks. Maybe someone else can review

Oh, i see, thanks for reply!

@potiuk Can you please check then? :)

@MaksYermak MaksYermak force-pushed the apache-kafka-clusters branch 6 times, most recently from ec40cc1 to 1aa4c4f Compare February 12, 2025 09:34
@MaksYermak
Copy link
Contributor Author

@eladkal @potiuk could you please check this PR again?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @eladkal ?

@MaksYermak MaksYermak force-pushed the apache-kafka-clusters branch 2 times, most recently from af847e7 to 90c63ba Compare February 17, 2025 12:13
@eladkal eladkal dismissed their stale review February 17, 2025 12:14

no time to re-review. leave it for other committers to check

@potiuk potiuk force-pushed the apache-kafka-clusters branch from 90c63ba to f20fb66 Compare February 17, 2025 13:08
@potiuk potiuk merged commit fece9c7 into apache:main Feb 17, 2025
149 checks passed
@dstandish
Copy link
Contributor

@MaksYermak do you have any idea what's going on with the kafka messages here?

https://github.com/apache/airflow/actions/runs/13555901653/job/37890520619?pr=46503#step:6:5930

@MaksYermak
Copy link
Contributor Author

@MaksYermak do you have any idea what's going on with the kafka messages here?

https://github.com/apache/airflow/actions/runs/13555901653/job/37890520619?pr=46503#step:6:5930

Hello @dstandish,
All that I can say is that something happened with kafka cluster, which can be accessible by this url localhost:9092/bootstrap, maybe this cluster does not exist, because this url for me looks like default one. Or maybe consumer and producer functions do not have enough permissions to connect to the cluster. But it's hard for me to say what exactly happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants