-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create operators for working with Clusters for GCP Apache Kafka #45795
Conversation
hi @potiuk ! Can you please check changes from this PR? :) |
providers/src/airflow/providers/google/cloud/hooks/apache_kafka.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/google/cloud/hooks/apache_kafka.py
Outdated
Show resolved
Hide resolved
03d48d3
to
57c8744
Compare
@eladkal I have updated the naming for hook and operators. Could you please check PR one more time? |
Hi @eladkal ! Can you please check changes here? Thanks :) |
sorry won't get to it in the next 1-2 weeks. Maybe someone else can review |
ec40cc1
to
1aa4c4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @eladkal ?
af847e7
to
90c63ba
Compare
no time to re-review. leave it for other committers to check
90c63ba
to
f20fb66
Compare
@MaksYermak do you have any idea what's going on with the kafka messages here? https://github.com/apache/airflow/actions/runs/13555901653/job/37890520619?pr=46503#step:6:5930 |
Hello @dstandish, |
In this PR I have created operators for working with Clusters for GCP Managed Service for Apache Kafka
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.