Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fastapi-api command to api-server #47076

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Move fastapi-api command to api-server #47076

merged 3 commits into from
Feb 26, 2025

Conversation

jedcunningham
Copy link
Member

@jedcunningham jedcunningham commented Feb 25, 2025 •
edited
Loading

Time to move the cli command to it's final home: api-server

This also moves the base_url config option into the api section.

@jedcunningham jedcunningham added the full tests needed We need to run full set of tests for this PR to merge label Feb 25, 2025
@jedcunningham jedcunningham reopened this Feb 25, 2025
vincbeck
vincbeck reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well: https://github.com/apache/airflow/blob/main/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py#L162

bugraoz93
bugraoz93 reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good!

We have one more here in the AWS provider auth_manager, it may fail since the configuration has changed.

https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py#L87

@vincbeck
Copy link
Contributor

Thanks a lot! Looks good!

We have one more here in the AWS provider auth_manager, it may fail since the configuration has changed.

https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py#L87

Good catch! :)

@jedcunningham
Copy link
Member Author

Thanks, my grepping failed me!

@jedcunningham jedcunningham marked this pull request as ready for review February 25, 2025 21:06
@jedcunningham jedcunningham mentioned this pull request Feb 25, 2025
Draft
pierrejeambrun
pierrejeambrun approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jedcunningham jedcunningham merged commit 6332afc into apache:main Feb 26, 2025
155 of 171 checks passed
@jedcunningham jedcunningham deleted the fastapi_api_to_api_server branch February 26, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck left review comments

@potiuk potiuk potiuk approved these changes

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:CLI area:dev-tools area:helm-chart Airflow Helm Chart full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jedcunningham @vincbeck @potiuk @bugraoz93 @pierrejeambrun