Skip to content

feat: display a warning message when the data plane has write access to etcd #12207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented May 13, 2025

Description

In short, as long as APISIX is deployed in decoupled mode with the role set to data_plane, and it can successfully write to etcd, a warning message will be displayed.

A warning message will be displayed under the following conditions:

  1. Etcd allows anonymous access, enabling the data plane to write to etcd.
  2. The configured etcd user has write permissions.

No warning will be shown in the following case:

  1. The configured etcd user has read-only permissions.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@LiteSun LiteSun changed the title feat: implement etcd token retrieval and write permission check for d… feat: display a warning message when the data plane has write access to etcd May 20, 2025
@LiteSun LiteSun marked this pull request as ready for review May 20, 2025 14:01
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels May 20, 2025
@LiteSun LiteSun marked this pull request as draft May 21, 2025 01:51
@LiteSun
Copy link
Member Author

LiteSun commented May 21, 2025

After discussions with @moonming and @nic-6443, we found that checking etcd write permissions during the APISIX startup phase is not very accurate, especially under different etcd cluster permission configurations. A new PR will be submitted to display a warning message when a write operation to etcd is attempted.

@LiteSun LiteSun closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant