Remove deprecated try_with_option methods (#5237)

apache · Dec 23, 2023 · a9d219b · a9d219b
1 parent c6f8bb5
commit a9d219b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 61 deletions.
diff --git a/object_store/src/aws/builder.rs b/object_store/src/aws/builder.rs
@@ -477,29 +477,6 @@ impl AmazonS3Builder {
         self
     }
 
-    /// Set an option on the builder via a key - value pair.
-    ///
-    /// This method will return an `UnknownConfigKey` error if key cannot be parsed into [`AmazonS3ConfigKey`].
-    #[deprecated(note = "Use with_config")]
-    pub fn try_with_option(self, key: impl AsRef<str>, value: impl Into<String>) -> Result<Self> {
-        Ok(self.with_config(key.as_ref().parse()?, value))
-    }
-
-    /// Hydrate builder from key value pairs
-    ///
-    /// This method will return an `UnknownConfigKey` error if any key cannot be parsed into [`AmazonS3ConfigKey`].
-    #[deprecated(note = "Use with_config")]
-    #[allow(deprecated)]
-    pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl Into<String>)>>(
-        mut self,
-        options: I,
-    ) -> Result<Self> {
-        for (key, value) in options {
-            self = self.try_with_option(key, value)?;
-        }
-        Ok(self)
-    }
-
     /// Get config value via a [`AmazonS3ConfigKey`].
     ///
     /// # Example

diff --git a/object_store/src/azure/builder.rs b/object_store/src/azure/builder.rs
@@ -521,25 +521,6 @@ impl MicrosoftAzureBuilder {
         self
     }
 
-    /// Set an option on the builder via a key - value pair.
-    #[deprecated(note = "Use with_config")]
-    pub fn try_with_option(self, key: impl AsRef<str>, value: impl Into<String>) -> Result<Self> {
-        Ok(self.with_config(key.as_ref().parse()?, value))
-    }
-
-    /// Hydrate builder from key value pairs
-    #[deprecated(note = "Use with_config")]
-    #[allow(deprecated)]
-    pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl Into<String>)>>(
-        mut self,
-        options: I,
-    ) -> Result<Self> {
-        for (key, value) in options {
-            self = self.try_with_option(key, value)?;
-        }
-        Ok(self)
-    }
-
     /// Get config value via a [`AzureConfigKey`].
     ///
     /// # Example

diff --git a/object_store/src/gcp/builder.rs b/object_store/src/gcp/builder.rs
@@ -287,25 +287,6 @@ impl GoogleCloudStorageBuilder {
         self
     }
 
-    /// Set an option on the builder via a key - value pair.
-    #[deprecated(note = "Use with_config")]
-    pub fn try_with_option(self, key: impl AsRef<str>, value: impl Into<String>) -> Result<Self> {
-        Ok(self.with_config(key.as_ref().parse()?, value))
-    }
-
-    /// Hydrate builder from key value pairs
-    #[deprecated(note = "Use with_config")]
-    #[allow(deprecated)]
-    pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl Into<String>)>>(
-        mut self,
-        options: I,
-    ) -> Result<Self> {
-        for (key, value) in options {
-            self = self.try_with_option(key, value)?;
-        }
-        Ok(self)
-    }
-
     /// Get config value via a [`GoogleConfigKey`].
     ///
     /// # Example