Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustfmt default line width #4960

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 19, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Aggressive column widths just add vertical bloat, and make code harder to parse. This is a frequent source of frustration for me, as spreading code over lots of lines makes it harder to navigate.

For example

image

image

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 19, 2023
@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet-derive object-store Object Store Interface labels Oct 19, 2023
@@ -16,9 +16,3 @@
# under the License.

edition = "2021"
max_width = 90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes a lot of sense to use the rustfmt default 👍

@tustvold tustvold merged commit 7e134f4 into apache:master Oct 19, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants