Parquet: Fix string display for f32/f64 zero values #5046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the issue with 0E0? I agree it looks a little odd, but it isn't incorrect? |
Yeah I wasn't sure if this was intended or not. It felt like a bug since the code seemed to suggest it used the E notation for very large positive/negative numbers, and 0E0 just happened to be caught up in it accidentally. When I was implementing f16 (#5003) I wasn't sure if we should display 0E0 to be consistent or just have it display 0.0 anyway If this is behaviour is fine then can close the PR |
|
I don't have a good enough sense of what people are using the record API for to be comfortable making breaking changes to it |
|
No problem, closing as no need to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5045
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?