Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet f32/f64 handle signed zeros in statistics #5048

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Nov 7, 2023

Which issue does this PR close?

Relates to #5047

Rationale for this change

What changes are included in this PR?

Implement fix for f32/f64

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 7, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, what a mess 😆

@tustvold tustvold merged commit ffeda62 into apache:master Nov 7, 2023
@Jefffrey Jefffrey deleted the float_stats_signed_zero branch November 7, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants