Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ByteBufferPtr and replace with Bytes #5055

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Remove ByteBufferPtr and replace with Bytes #5055

merged 3 commits into from
Nov 8, 2023

Conversation

Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Nov 7, 2023

Which issue does this PR close?

Closes #1474

Rationale for this change

What changes are included in this PR?

Remove parquet/src/util/memory.rs file/mod

Replace all usages of ByteBufferPtr with bytes::Bytes

Are there any user-facing changes?

Deleted the parquet::util::memory module, but this was marked as experimental

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 7, 2023
tustvold
tustvold approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍

@tustvold tustvold merged commit 1635f5b into apache:master Nov 8, 2023
16 checks passed
@Jefffrey Jefffrey deleted the remove_byte_buffer_ptr branch November 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Custom Buffer Implementation with Bytes in Parquet
2 participants
@Jefffrey @tustvold