refactor: change object_store CA handling
#5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Nov 8, 2023
| @@ -86,6 +86,17 @@ | |||
| doc = "* [`http`]: [HTTP/WebDAV Storage](https://datatracker.ietf.org/doc/html/rfc2518). See [`HttpBuilder`](http::HttpBuilder)" | |||
| )] | |||
| //! | |||
| //! # TLS Certificates | |||
There was a problem hiding this comment.
Could we perhaps move this lower, e.g. after the configuration section. I don't think this should be the first thing users see
There was a problem hiding this comment.
ups, fat-fingered the merge, will do in a follow-up
crepererum
added a commit
that referenced
this pull request
Nov 8, 2023
This reverts commit 0cb30bb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4870.
Rationale for this change
See issue. Alternative to #5030.
What changes are included in this PR?
Feature switches to opt into webpki.
Are there any user-facing changes?
Breaking: Use system certs by default.