Add option to disable writing of Parquet offset index #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Nov 26, 2024
parquet/src/file/metadata/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Disable writing of offset indexes. |
There was a problem hiding this comment.
What is the motivation for building this into the builder, as opposed to simply wrapping the OffsetIndexBuilder in Option?
There was a problem hiding this comment.
Analogy with column index builder? Lack of imagination? 🤷 Changed.
There was a problem hiding this comment.
Should column_index_builder get similar treatment?
There was a problem hiding this comment.
Possibly, although probably not worth making a breaking change over if it is public
There was a problem hiding this comment.
I never realized that the builders were public. Guess it's not worth the refactor to make column_index_builder an Option too.
tustvold
approved these changes
Nov 27, 2024
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6778.
Rationale for this change
Allow disabling offset indexes.
What changes are included in this PR?
Adds a global
offset_index_disabledwriter property. This was made global rather than per-column because the index is not very useful if not defined for all columns.Are there any user-facing changes?
Yes, adds a new property.