-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18391: [R] Fix the version selector dropdown in the dev docs #14800
ARROW-18391: [R] Fix the version selector dropdown in the dev docs #14800
Conversation
|
Can I confirm what problem is fixed by this? I confirmed the current https://arrow.apache.org/docs/r/ . The version dropdown shows "10.0.0.9000 (dev)" not "10.0.0 (release)". Is it a problem that is fixed by this PR? I also confirmed that "9.0.0" in https://arrow.apache.org/docs/r/ can move to https://arrow.apache.org/docs/9.0/r/ . I think that it's expected. |
The problem is that in a recent PR (since 10.0.1) we upgraded to Bootstrap 5 from Bootstrap 3. In the HTML templates which the pkgdown package (used to generate the docs) uses, there is a span called "version" in the template for Bootstrap 3 but not for Bootstrap 5. The JavaScript we use to implement the version switcher replaces that span with the version switcher. In the dev docs, the version switcher is not working because of this: https://arrow.apache.org/docs/dev/r/ I'll update the title to make that more clear, as it's not apparent, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I understand.
I couldn't confirm the change details but +1 because you showed that it works on your local.
Benchmark runs are scheduled for baseline = 7f04d91 and contender = f51ea4d. f51ea4d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
For context, this overrides the default navbar HTML with a custom version which makes a single change - adding a span called "version" which the JS will override. An identically-named span existed in the template used with Bootstrap 3, which is why no JavaScript changes were needed. This approach is almost identical to that in this PR to the pkgdown package which implements the same thing: r-lib/pkgdown#2072
I built this locally, and it appears to have successfully added the dropdown back in.