GH-46149: [C++] Opening dataset fails with sshfs-3.7.3 due to F_RDADVISE error #46346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions autotune |
pitrou
reviewed
May 12, 2025
cpp/src/arrow/io/caching.cc
Outdated
| @@ -188,7 +188,9 @@ struct ReadRangeCache::Impl { | |||
| entries = std::move(new_entries); | |||
| } | |||
| // Prefetch immediately, regardless of executor availability, if possible | |||
| return file->WillNeed(ranges); | |||
| // As this is optimisation only, failures should not be treated as fatal | |||
| ARROW_UNUSED(file->WillNeed(ranges)); | |||
There was a problem hiding this comment.
I would rather we just ignore IOError but less other errors propagate (they might be indicative of a logic error).
There was a problem hiding this comment.
Gotcha, have updated it now.
thisisnic
force-pushed
the
gh-46149_fradvise
branch
from
fee89f2 to
195d032
Compare
github-actions
bot
added
awaiting changes
|
Thanks @thisisnic 🥇 .... bummer we missed 20.0.0 a couple of days, 🤞 a patch-release is soon :-) |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c3855b9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 35 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix a bug where cache optimisation errors prevent files being read
What changes are included in this PR?
No longer treat
WillNeederrors inReadRangeCache::Cacheas fatalAre these changes tested?
No
Are there any user-facing changes?
No