ATLAS-5006 : Atlas incremental export takes too much time (almost equ… #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
reviewed
Mar 21, 2025
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Outdated
Show resolved
Hide resolved
mandarambawane
force-pushed
the
ATLAS-5006-0321-1724
branch
2 times, most recently
from
5611589 to
1b68e37
Compare
mneethiraj
reviewed
Mar 26, 2025
| @@ -482,6 +482,10 @@ public AtlasEntitiesWithExtInfo toAtlasEntitiesWithExtInfo(List<String> guids, b | |||
| return ret; | |||
| } | |||
|
|
|||
| public List<AtlasVertex> findAllRelationshipVertices(AtlasVertex vertex) { | |||
There was a problem hiding this comment.
findAllRelationshipVertices() => findAllConnectedVertices()
| } | ||
|
|
||
| public void extractRelatedVertices(AtlasVertex vertex, ExportContext context) { | ||
| List<AtlasVertex> relationshipEntities = entityGraphRetriever.findAllRelationshipVertices(vertex); |
There was a problem hiding this comment.
findAllRelationshipVertices() => findAllConnectedVertices()
| List<AtlasVertex> relationshipEntities = entityGraphRetriever.findAllRelationshipVertices(vertex); | ||
| if (CollectionUtils.isNotEmpty(relationshipEntities)) { | ||
| for (AtlasVertex e : relationshipEntities) { | ||
| String relGuid = AtlasGraphUtilsV2.getEncodedProperty(e, GUID_PROPERTY_KEY, String.class); |
There was a problem hiding this comment.
Verify that the vertex represents an entity before processing it further.
String typeName = GraphHelper.getTypeName(e);
if (typeRegistry.getEntityTypeByName(typeName) != null) {
String guid = AtlasGraphUtilsV2.getEncodedProperty(e, GUID_PROPERTY_KEY, String.class);
if (!context.guidsProcessed.contains(guid)) {
context.guidsToProcess.add(guid);
}
}
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Show resolved
Hide resolved
mneethiraj
approved these changes
Mar 27, 2025
mandarambawane
force-pushed
the
ATLAS-5006-0321-1724
branch
2 times, most recently
from
b58fda1 to
868a577
Compare
…ivalent to bootstrap export with the entire data)
mandarambawane
force-pushed
the
ATLAS-5006-0321-1724
branch
from
868a577 to
4d734cb
Compare
pinal-shah
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ivalent to bootstrap export with the entire data)
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. ATLAS-XXXX: Fix a typo in YYY))
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)