CASSANDRA-20362: add setcachecapacity to nodetool #3925
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maoling
commented
Feb 23, 2025
maoling
commented
- more details in the CASSANDRA-20362
Maxwell-Guo
reviewed
Feb 23, 2025
| @Arguments(title = "<key-cache-period> <row-cache-period> <counter-cache-period>", | ||
| usage = "<key-cache-period> <row-cache-period> <counter-cache-period>", | ||
| description = "Key cache, row cache, and counter period (unit: second)", | ||
| required = true) |
There was a problem hiding this comment.
you need to add test case for this
| @Override | ||
| public void execute(NodeProbe probe) | ||
| { | ||
| checkArgument(args.size() == 3, "setcacheperiod requires key-cache-period, row-cache-period, and counter-cache-period args."); |
There was a problem hiding this comment.
I think you can add some argument -k for keyache , -r for row cache, -c for counter
And I think not all of these arguments are needed at one time for user.
There was a problem hiding this comment.
I found your code has the same format with SetCacheCapacity/SetCacheKeysToSave , I'm not forcing you to do this now.
Maxwell-Guo
reviewed
Feb 24, 2025
|
|
||
| import static com.google.common.base.Preconditions.checkArgument; | ||
|
|
||
| @Command(name = "setcacheperiod", description = "Set global key, row, and counter cache period (unit: second)") |
There was a problem hiding this comment.
change to : Set global key, row, and counter cache period in second units
Besides setting it to 0 seems meaningless.
Maxwell-Guo
reviewed
Feb 24, 2025
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import io.airlift.airline.Arguments; |
There was a problem hiding this comment.
See CASSANDRA-17445 airlift will be deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.