CASSANDRA-20360: Improve performance of DistributedSchema.validate for large schemas #3926
+131
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beobal
reviewed
Feb 24, 2025
| } | ||
|
|
||
| Keyspaces keyspaces = Keyspaces.of(keyspaceMetadatas.toArray(new KeyspaceMetadata[numKeyspaces])); | ||
| schema = new BenchmarkingDistributedSchema(keyspaces, Epoch.EMPTY, false); |
There was a problem hiding this comment.
Because the test is performing multiple iterations anyway, is there much to be gained by making validate conditional in the DistributedSchema constructor?
There was a problem hiding this comment.
I wanted to remove the constructor from the benchmark measurement because it calls BTreeMap#with for each keyspace, which isn't cheap in a loop. But both benchmarks would be including this path, so the comparison would still stand, would just have more noise. Happy to revert the test constructor change, remove the benchmark, or both - let me know what you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.