-
Notifications
You must be signed in to change notification settings - Fork 117
polish: Fix some inconsistencies in object names and messages #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
abh1sar
wants to merge
2
commits into
apache:4.20
Choose a base branch
from
abh1sar:ui-polish-pr
base: 4.20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -315,7 +315,7 @@ Define a Network Access Control List (ACL) to control incoming | |||||||||
(ingress) and outgoing (egress) traffic between the associated Network Tier | ||||||||||
and external Networks (other Network Tiers of the VPC as well as public Networks). | ||||||||||
|
||||||||||
About Network ACL Lists | ||||||||||
About Network ACLs | ||||||||||
^^^^^^^^^^^^^^^^^^^^^^^ | ||||||||||
|
||||||||||
In CloudStack terminology, a Network ACL is a group of Network ACL rules. | ||||||||||
|
@@ -357,7 +357,7 @@ Afterwards traffic can be white- or blacklisted. | |||||||||
connection | ||||||||||
|
||||||||||
|
||||||||||
Creating ACL Lists | ||||||||||
Creating ACLs | ||||||||||
^^^^^^^^^^^^^^^^^^ | ||||||||||
Comment on lines
+360
to
361
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
#. Log in to the CloudStack UI as an administrator or end User. | ||||||||||
|
@@ -391,18 +391,18 @@ Creating ACL Lists | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. Select Network ACL Lists. | ||||||||||
#. Select Network ACLs. | ||||||||||
|
||||||||||
The following default rules are displayed in the Network ACLs page: | ||||||||||
default\_allow, default\_deny. | ||||||||||
|
||||||||||
#. Click Add ACL Lists, and specify the following: | ||||||||||
#. Click Add Network ACL, and specify the following: | ||||||||||
|
||||||||||
- **ACL List Name**: A name for the ACL list. | ||||||||||
- **ACL Name**: A name for the ACL. | ||||||||||
|
||||||||||
- **Description**: A short description of the ACL list that can be | ||||||||||
- **Description**: A short description of the ACL that can be | ||||||||||
displayed to users. | ||||||||||
|
||||||||||
|
||||||||||
|
@@ -420,15 +420,15 @@ Creating an ACL Rule | |||||||||
|
||||||||||
#. Click the Configure button of the VPC. | ||||||||||
|
||||||||||
#. Select Network ACL Lists. | ||||||||||
#. Select Network ACLs. | ||||||||||
|
||||||||||
In addition to the custom ACL lists you have created, the following | ||||||||||
In addition to the custom ACLs you have created, the following | ||||||||||
default rules are displayed in the Network ACLs page: default\_allow, | ||||||||||
default\_deny. | ||||||||||
|
||||||||||
#. Select the desired ACL list. | ||||||||||
#. Select the desired ACL. | ||||||||||
|
||||||||||
#. Select the ACL List Rules tab. | ||||||||||
#. Select the ACL Rules tab. | ||||||||||
|
||||||||||
To add an ACL rule, fill in the following fields to specify what kind | ||||||||||
of network traffic is allowed in the VPC. | ||||||||||
|
@@ -471,23 +471,23 @@ Creating an ACL Rule | |||||||||
tab. | ||||||||||
|
||||||||||
|
||||||||||
Creating a Tier with Custom ACL List | ||||||||||
Creating a Tier with Custom ACL | ||||||||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||||||||||
Comment on lines
+474
to
475
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
#. Create a VPC. | ||||||||||
|
||||||||||
#. Create a custom ACL list. | ||||||||||
#. Create a custom ACL. | ||||||||||
|
||||||||||
#. Add ACL rules to the ACL list. | ||||||||||
#. Add ACL rules to the ACL. | ||||||||||
|
||||||||||
#. Create a tier in the VPC. | ||||||||||
|
||||||||||
Select the desired ACL list while creating a tier. | ||||||||||
Select the desired ACL while creating a tier. | ||||||||||
|
||||||||||
#. Click OK. | ||||||||||
|
||||||||||
|
||||||||||
Assigning a Custom ACL List to a Tier | ||||||||||
Assigning a Custom ACL to a Tier | ||||||||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||||||||||
Comment on lines
+490
to
491
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
#. Create a VPC. | ||||||||||
|
@@ -496,17 +496,17 @@ Assigning a Custom ACL List to a Tier | |||||||||
|
||||||||||
#. Associate the tier with the default ACL rule. | ||||||||||
|
||||||||||
#. Create a custom ACL list. | ||||||||||
#. Create a custom ACL. | ||||||||||
|
||||||||||
#. Add ACL rules to the ACL list. | ||||||||||
#. Add ACL rules to the ACL. | ||||||||||
|
||||||||||
#. Select the tier for which you want to assign the custom ACL. | ||||||||||
|
||||||||||
#. Click the Replace ACL List icon. |replace-acl-icon.png| | ||||||||||
#. Click the Replace ACL icon. |replace-acl-icon.png| | ||||||||||
|
||||||||||
The Replace ACL List dialog is displayed. | ||||||||||
The Replace ACL dialog is displayed. | ||||||||||
|
||||||||||
#. Select the desired ACL list. | ||||||||||
#. Select the desired ACL. | ||||||||||
|
||||||||||
#. Click OK. | ||||||||||
|
||||||||||
|
@@ -558,7 +558,7 @@ with duplicated VLAN and IP are allowed in the same data center. | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. Select Private Gateways. | ||||||||||
|
||||||||||
|
@@ -801,7 +801,7 @@ associated to more than one network at a time. | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. Select IP Addresses. | ||||||||||
|
||||||||||
|
@@ -859,7 +859,7 @@ still belongs to the same VPC. | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. Select Public IP Addresses. | ||||||||||
|
||||||||||
|
@@ -920,7 +920,7 @@ function only if they are defined on the default network. | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. In the Router node, select Public IP Addresses. | ||||||||||
|
||||||||||
|
@@ -1086,7 +1086,7 @@ Creating an External LB Rule | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. In the Router node, select Public IP Addresses. | ||||||||||
|
||||||||||
|
@@ -1354,7 +1354,7 @@ Adding a Port Forwarding Rule on a VPC | |||||||||
|
||||||||||
- Site-to-Site VPNs | ||||||||||
|
||||||||||
- Network ACL Lists | ||||||||||
- Network ACLs | ||||||||||
|
||||||||||
#. In the Router node, select Public IP Addresses. | ||||||||||
|
||||||||||
|
@@ -1473,7 +1473,7 @@ is not required. | |||||||||
.. |add-tier.png| image:: /_static/images/add-tier.png | ||||||||||
:alt: adding a tier to a vpc. | ||||||||||
.. |replace-acl-icon.png| image:: /_static/images/replace-acl-icon.png | ||||||||||
:alt: button to replace an ACL list | ||||||||||
:alt: button to replace an ACL | ||||||||||
.. |add-new-gateway-vpc2.png| image:: /_static/images/add-new-gateway-vpc2.png | ||||||||||
:alt: adding a private gateway for the VPC. | ||||||||||
.. |add-vm-vpc.png| image:: /_static/images/add-vm-vpc.png | ||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -829,7 +829,7 @@ it is upgraded: | |
|
||
- SecurityGroup | ||
|
||
- UserData | ||
- User Data | ||
|
||
- DHCP | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.