Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vTPM: support KVM and VMware #10543

Draft
wants to merge 4 commits into
base: 4.20
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR adds the vTPM support for VMs on KVM and VMware

  • UEFI must be set to "SECURE"
    image

  • For VMs and templates on KVM

image

image

  • For VMs and templates on VMware

image

  • CPU mode/model for VMs on KVM (root admin only)

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 42.05607% with 62 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (54c1f92) to head (771dfce).

Files with missing lines Patch % Lines
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 33 Missing ⚠️
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 72.91% 12 Missing and 1 partial ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 44.44% 6 Missing and 4 partials ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               4.20   #10543    +/-   ##
==========================================
  Coverage     16.00%   16.01%            
- Complexity    13103    13106     +3     
==========================================
  Files          5651     5651            
  Lines        495841   495946   +105     
  Branches      60045    60059    +14     
==========================================
+ Hits          79373    79417    +44     
- Misses       407606   407663    +57     
- Partials       8862     8866     +4     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.85% <42.05%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12735

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12651)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10543-t12651-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1521.42 test_network.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants