Skip to content

polish: Fix some inconsistencies in object names and messages #10856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: 4.20
Choose a base branch
from

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented May 13, 2025

Description

This PR fixes some inconsistencies in object names and messages.
doc pr : apache/cloudstack-documentation#506

ACL Lists

  1. Replace ACL Lists with ACLs as Access Control List Lists doesn't make sense
  2. Replace Add ACL with Add ACL rule wherever a rule is being added

Before:
Screenshot 2025-05-13 at 2 01 19 PM
After:
Screenshot 2025-05-13 at 2 01 31 PM
Before:
Screenshot 2025-05-13 at 2 03 00 PM
After:
Screenshot 2025-05-13 at 2 03 11 PM

User data

  1. Following industry conventions, User data should be written as two words
  2. The term "User Data" used in the main menu creates some confusion, whether it is singular or plural. So renamed it to "User Data Library" where users can register new User Data.
  3. User data should not be followed by "a"

Before:
Screenshot 2025-05-13 at 2 04 42 PM
After:
Screenshot 2025-05-13 at 2 05 04 PM
Before:
Screenshot 2025-05-13 at 2 06 55 PM
After:
Screenshot 2025-05-13 at 2 07 21 PM

Use Title Case in main menu and create new * buttons

List of all changes done:
TitleCase.txt

Before:
Screenshot 2025-05-13 at 2 09 37 PM
After:
Screenshot 2025-05-13 at 2 14 08 PM

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.00%. Comparing base (011fced) to head (c55630f).
Report is 8 commits behind head on 4.20.

❗ There is a different number of reports uploaded between BASE (011fced) and HEAD (c55630f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (011fced) HEAD (c55630f)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.20   #10856       +/-   ##
=============================================
- Coverage     16.13%    4.00%   -12.13%     
=============================================
  Files          5652      400     -5252     
  Lines        497021    32555   -464466     
  Branches      60222     5770    -54452     
=============================================
- Hits          80202     1305    -78897     
+ Misses       407885    31101   -376784     
+ Partials       8934      149     -8785     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland changed the title Polish: Fix some inconsistencies in object names and messages polish: Fix some inconsistencies in object names and messages May 13, 2025
@abh1sar abh1sar requested a review from sureshanaparti May 20, 2025 15:01
"label.add.intermediate.certificate": "Add intermediate certificate",
"label.add.host": "Add Host",
"label.add.ingress.rule": "Add Ingress rule",
"label.add.intermediate.certifrcate": "Add intermediate certificate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label.add.intermediate.certifrcate": "Add intermediate certificate",
"label.add.intermediate.certificate": "Add intermediate certificate",

"label.userdataname": "User data name",
"label.userdatadetails": "User data details",
"label.userdataparams": "User data parameters",
"label.userdatapolicy": "User data link policy",
Copy link
Contributor

@sureshanaparti sureshanaparti May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update label keys as well -label.user.data.id|name|details|...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants