Skip to content

ui: do not filter edge zones while registering directdownload iso #10865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #10766

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr shwstppr changed the title ui: donot filter edge zones while registering directdownload iso ui: do not filter edge zones while registering directdownload iso May 14, 2025
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10865 (QA-JID-622)

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.26%. Comparing base (7e2aa0e) to head (45209dc).
Report is 137 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10865      +/-   ##
============================================
+ Coverage     16.13%   17.26%   +1.13%     
- Complexity    13217    13630     +413     
============================================
  Files          5651     5304     -347     
  Lines        496748   471068   -25680     
  Branches      60184    55243    -4941     
============================================
+ Hits          80137    81341    +1204     
+ Misses       407688   380691   -26997     
- Partials       8923     9036     +113     
Flag Coverage Δ
uitests ?
unittests 17.26% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if (this.form.zoneid && this.zoneList.find(entry => entry.id === this.form.zoneid)) {
return
}
this.form.zoneid = this.zoneList?.[0]?.id || ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr
line 485 set the this.form.zoneid to the id of first zone , is it needed ?

Copy link
Contributor Author

@shwstppr shwstppr May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache yes. This is for the case when the user selects direct-download, then selects an edge zone but then changes direct-download to false. Earlier selected zone will not be available now so the code selects the first zone from the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Unable to select edge zone during iso registration
3 participants