-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: do not filter edge zones while registering directdownload iso #10865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes apache#10766 Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10865 +/- ##
============================================
+ Coverage 16.13% 17.26% +1.13%
- Complexity 13217 13630 +413
============================================
Files 5651 5304 -347
Lines 496748 471068 -25680
Branches 60184 55243 -4941
============================================
+ Hits 80137 81341 +1204
+ Misses 407688 380691 -26997
- Partials 8923 9036 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
if (this.form.zoneid && this.zoneList.find(entry => entry.id === this.form.zoneid)) { | ||
return | ||
} | ||
this.form.zoneid = this.zoneList?.[0]?.id || '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwstppr
line 485 set the this.form.zoneid to the id of first zone , is it needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weizhouapache yes. This is for the case when the user selects direct-download, then selects an edge zone but then changes direct-download to false. Earlier selected zone will not be available now so the code selects the first zone from the list
Description
Fixes #10766
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?