-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Allow accounts of the User
type to add other accounts or users to projects through UI
#9927
base: 4.19
Are you sure you want to change the base?
UI: Allow accounts of the User
type to add other accounts or users to projects through UI
#9927
Conversation
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9927 +/- ##
============================================
- Coverage 15.10% 4.30% -10.81%
============================================
Files 5404 366 -5038
Lines 473460 29550 -443910
Branches 57728 5174 -52554
============================================
- Hits 71525 1272 -70253
+ Misses 393941 28134 -365807
+ Partials 7994 144 -7850
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, tested in qa.c.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in a local lab and was able to add accounts and users to a project in a User
type account via the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested in qa.c.c
Description
Currently, to add a user or account to a project through UI, a select input field is rendered, displaying the accounts and users that the caller has access to as options. As a result, users with an account of the
User
type are unable to add other accounts or users to a project, since they don't have access to other accounts or users and no options are available to be selected in the input field.This PR modifies the input field to allow users to both select from the available options and manually enter the account name or username they wish to add to the project.
Fixes #9774
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Adding an account by selecting an option available in the dropdown
Adding a user by entering their username in the input field
How Has This Been Tested?
d1
, a domain admin (d1
) and two normal users (u1-d1
andu2-d1
) belonging to the domain.d1
account.d1
account can select accounts and users of their domain to add them to the project.u1-d1
account to the project as an admin.u1-d1
account, accessed the project and added the useru2-d1
to the project.