Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allow accounts of the User type to add other accounts or users to projects through UI #9927

Open
wants to merge 5 commits into
base: 4.19
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Collaborator

Description

Currently, to add a user or account to a project through UI, a select input field is rendered, displaying the accounts and users that the caller has access to as options. As a result, users with an account of the User type are unable to add other accounts or users to a project, since they don't have access to other accounts or users and no options are available to be selected in the input field.

This PR modifies the input field to allow users to both select from the available options and manually enter the account name or username they wish to add to the project.


Fixes #9774

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Adding an account by selecting an option available in the dropdown

image

Adding a user by entering their username in the input field

image

How Has This Been Tested?

  1. I created a domain d1, a domain admin (d1) and two normal users (u1-d1 and u2-d1) belonging to the domain.
  2. I created a project with the d1 account.
  3. I verified that the d1 account can select accounts and users of their domain to add them to the project.
  4. I added the u1-d1 account to the project as an admin.
  5. I logged in with the u1-d1 account, accessed the project and added the user u2-d1 to the project.

@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.30%. Comparing base (03bdf11) to head (358e77c).
Report is 7 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (03bdf11) and HEAD (358e77c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (03bdf11) HEAD (358e77c)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #9927       +/-   ##
============================================
- Coverage     15.10%   4.30%   -10.81%     
============================================
  Files          5404     366     -5038     
  Lines        473460   29550   -443910     
  Branches      57728    5174    -52554     
============================================
- Hits          71525    1272    -70253     
+ Misses       393941   28134   -365807     
+ Partials       7994     144     -7850     
Flag Coverage Δ
uitests 4.30% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9927 (QA-JID-478)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested in qa.c.c

Copy link
Collaborator

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in a local lab and was able to add accounts and users to a project in a User type account via the UI.

Copy link
Collaborator

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in qa.c.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants