Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Java versions from dependency statement #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elharo
Copy link

@elharo elharo commented Jun 21, 2024

@garydgregory
Copy link
Member

@elharo
That's not what the POM says. It requires Java 8.

@elharo
Copy link
Author

elharo commented Jun 21, 2024

which is why I removed the note saying that Java 5 is required

@aherbert
Copy link
Contributor

I think this change is fine. The reference to Java 1.2 and 1.5 are no longer relevant and adding back a different Java version adds a maintenance burden syncing the required java version across various documentation.

@elharo
Copy link
Author

elharo commented Jun 21, 2024

Java 8 CI for Mac is borked:

Run actions/setup-java@9704b39bf258b59bc04b50fa2dd55e9ed76b47a8
Installed distributions
  Trying to resolve the latest version from remote
  Error: Could not find satisfied version for SemVer '8'. 
  Available versions: 22.0.1+8, 22.0.0+36, 21.0.3+9.0.LTS, 21.0.2+13.0.LTS, 21.0.1+12.0.LTS, 21.0.0+35.0.LTS, 20.0.2+9, 20.0.1+9, 20.0.0+36, 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 17.0.11+9, 17.0.10+7, 17.0.9+9, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 11.0.23+9, 11.0.22+7.1, 11.0.22+7, 11.0.21+9, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10

@aherbert
Copy link
Contributor

Re MacOS, I think we have to switch the setup-java distribution to zulu. Or just drop the windows and mac os from the actions given the code does not use anything platform dependent. I'll push a change to master using zulu and see what happens.

@aherbert
Copy link
Contributor

Switching to zulu has fixed the master build.

@garydgregory
Copy link
Member

The simplest is to use macos-13.
The title here is "Assume everyone is on Java 5 or later" which is not the case, we need Java 8 or later.

@aherbert aherbert changed the title Assume everyone is on Java 5 or later Remove legacy Java versions from dependency statement Jun 21, 2024
@aherbert
Copy link
Contributor

The title is just from the commit message. The code change is to remove statements that spread the dependency information across site documentation (which is evidently not maintained in sync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants