Add isnan scalar function #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems broken: #472 |
|
CI should be fixed by #474 |
viirya
commented
Sep 8, 2023
| @@ -247,7 +248,7 @@ scalar_function!( | |||
| scalar_function!( | |||
| nanvl, | |||
| Nanvl, | |||
| "Computes the MD5 hash of the argument, with the result written in hexadecimal." | |||
There was a problem hiding this comment.
This function description was copied from MD5 previously, I think.
|
Ah, this repos still uses 29.0.0. Changed to draft until this upgrades to latest DataFusion. |
|
Close this as there is first time contributor's work #495. This is good first issue so it should be better to let new contributor work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Adding
isnanscalar function which exists in Rust library.What changes are included in this PR?
Are there any user-facing changes?