-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arrow cast #962
Open
kosiew
wants to merge
32
commits into
apache:main
Choose a base branch
from
kosiew:add-arrow-cast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add arrow cast #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions. Do you think this is needed or to just use Expr.cast
?
|
kosiew
force-pushed
the
add-arrow-cast
branch
from
December 12, 2024 10:22
6891f51
to
7e28012
Compare
So doing a little testing to see if this is necessary:
Produces:
So maybe we can use the existing method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Completes a task in #463
Rationale for this change
This PR introduces the implementation of the
arrow_cast
function from datafusion's similararrow_cast
function.What changes are included in this PR?
Functionality:
Implements the arrow_cast function
Tests:
Adds a test case to validate the functionality of arrow_cast.
Are there any user-facing changes?
Yes, this PR adds the
arrow_cast
function to the API, enabling users to columns into specific data type.