Skip to content

Snowflake: Add support for CONNECT_BY_ROOT #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

tomershaniii
Copy link
Contributor

Support for the snowflake CONNECT_BY_ROOT operator
https://docs.snowflake.com/en/sql-reference/constructs/connect-by

@tomershaniii tomershaniii changed the title Support for projection prefix operator (CONNECT_BY_ROOT) Support for projection item prefix operator (CONNECT_BY_ROOT) Mar 28, 2025
@iffyio iffyio marked this pull request as draft April 10, 2025 05:21
@iffyio
Copy link
Contributor

iffyio commented Apr 10, 2025

Marking as draft in the meantime as this PR is no longer pending review. @tomershaniii please feel free to undraft and ping when ready!

@tomershaniii tomershaniii force-pushed the support-select-item-prefix-operator branch from 24b1596 to ebe9107 Compare April 26, 2025 22:35
@tomershaniii tomershaniii force-pushed the support-select-item-prefix-operator branch from ebe9107 to 5cbf884 Compare April 26, 2025 22:42
@tomershaniii
Copy link
Contributor Author

Hi @iffyio , Modified the PR per you suggestion, please see if this is aligned to what you have in mind.

@tomershaniii tomershaniii marked this pull request as ready for review April 26, 2025 22:44
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomershaniii! I think this looks good overall to me, left some minor comments

@tomershaniii
Copy link
Contributor Author

Hi @iffyio , please see latest commit.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tomershaniii!
cc @alamb

@iffyio iffyio changed the title Support for projection item prefix operator (CONNECT_BY_ROOT) Snowflake: Add support for CONNECT_BY_ROOT Apr 29, 2025
@iffyio iffyio merged commit 2b5bdce into apache:main Apr 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants