Skip to content

Add license header to display_utils.rs and pretty_print.rs #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 16, 2025

When I tried to make a release caiddate for 0.57.0 I got some errors about files not having the Apache License:

Running rat license checker on /Users/andrewlamb/Software/sqlparser-rs/dev/dist/apache-datafusion-sqlparser-rs-0.57.0-rc1/apache-datafusion-sqlparser-rs-0.57.0.tar.gz
NOT APPROVED: src/display_utils.rs (apache-datafusion-sqlparser-rs-0.57.0/src/display_utils.rs): false
NOT APPROVED: tests/pretty_print.rs (apache-datafusion-sqlparser-rs-0.57.0/tests/pretty_print.rs): false

This PR adds the missing licenses

I will make another PR to add a license checking CI test

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iffyio iffyio merged commit 6f42396 into apache:main Jun 16, 2025
9 checks passed
@alamb alamb deleted the alamb/fix_licenses branch June 16, 2025 16:51
@alamb
Copy link
Contributor Author

alamb commented Jun 16, 2025

Thansk @iffyio -- I am now preparing the release candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants