Skip to content

Add support of parsing struct field's options in BigQuery #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025

Conversation

git-hulk
Copy link
Member

According to BigQuery syntax[1], the OPTIONS is allowed in both of top-level column definition and struct field.

[1] https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema

According to BigQuery syntax[1], the `OPTIONS` is allowed in both of
top-level column definition and struct field.

[1] https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
@git-hulk
Copy link
Member Author

cc @iffyio

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @git-hulk! Left a minor comment re comment/naming otherwise this looks good to me!

git-hulk and others added 2 commits June 17, 2025 19:59
Co-authored-by: Ifeanyi Ubah <[email protected]>
@git-hulk
Copy link
Member Author

@iffyio Thanks for your suggestions.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @git-hulk!
cc @alamb

@iffyio
Copy link
Contributor

iffyio commented Jun 17, 2025

@git-hulk could you take a look at the ci failure when you get the chance?

@git-hulk
Copy link
Member Author

@iffyio, I've changed the link to the Markdown style now.

@iffyio iffyio merged commit b1b379e into apache:main Jun 18, 2025
10 checks passed
@git-hulk git-hulk deleted the feature/allow-option-in-bigquery-struct branch June 18, 2025 05:31
@alamb
Copy link
Contributor

alamb commented Jun 18, 2025

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants