-
Notifications
You must be signed in to change notification settings - Fork 616
Add support of parsing struct field's options in BigQuery #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of parsing struct field's options in BigQuery #1890
Conversation
According to BigQuery syntax[1], the `OPTIONS` is allowed in both of top-level column definition and struct field. [1] https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema
cc @iffyio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @git-hulk! Left a minor comment re comment/naming otherwise this looks good to me!
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
@iffyio Thanks for your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@git-hulk could you take a look at the ci failure when you get the chance? |
@iffyio, I've changed the link to the Markdown style now. |
🎉 |
According to BigQuery syntax[1], the
OPTIONS
is allowed in both of top-level column definition and struct field.[1] https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema