Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sync constraint of SendableRecordBatchStream #1884

Merged
merged 2 commits into from
Mar 2, 2022
Merged

remove sync constraint of SendableRecordBatchStream #1884

merged 2 commits into from
Mar 2, 2022

Conversation

doki23
Copy link
Contributor

@doki23 doki23 commented Feb 25, 2022 •
edited
Loading

Which issue does this PR close?

close #1614

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Feb 25, 2022
@alamb
Copy link
Contributor

alamb commented Mar 1, 2022

cc @tustvold

@alamb alamb added the api change Changes the API exposed to users of the crate label Mar 1, 2022
alamb
alamb approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doki23

@alamb alamb mentioned this pull request Mar 1, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Mar 1, 2022

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

@doki23
Copy link
Contributor Author

doki23 commented Mar 2, 2022

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

No problem

houqp
houqp approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
Copy link
Contributor

alamb commented Mar 2, 2022

Thanks again @doki23 !

@alamb alamb merged commit 3c1252d into apache:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@houqp houqp houqp approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate datafusion Changes in the datafusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Sync from SendableRecordBatchStream
3 participants
@doki23 @alamb @houqp