Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with PATCH incorrectly replacing entire complex attr #726

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jasonfagerberg-toast
Copy link

Fix for: #725

@jasonfagerberg-toast
Copy link
Author

I think one issue here is if a complex attribute is within a complex attribute, i.e. this request

{
  "schemas": [
    "urn:ietf:params:scim:api:messages:2.0:PatchOp"
  ],
  "Operations": [
    {
      "op": "replace",

      "value": {
        "name": {
          "givenName": "New Given Name"
         }
      }
    }
  ]
}

I think the behavior will still be that name is replaced entirely but ill write a test to see

@jasonfagerberg-toast
Copy link
Author

I think the behavior will still be that name is replaced entirely but ill write a test to see

Added a test and its passing so nice work everyone, take off early for the day

Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @jasonfagerberg-toast!

I left a quick nit, but this change looks good, I'll make sure the CI build gets kicked off!

jasonfagerberg-toast and others added 2 commits January 17, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants