Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart sass #13937

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Dart sass #13937

merged 6 commits into from
Mar 16, 2023

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Mar 15, 2023

Description

Switch to Dart Sass so that the web console can be compiled on Mac arm64 architectures.

This necessitated two changes:

  • Shim the svg-icons function because we don't have access to it. Apparently it's possible to use from Blueprint's build system but this also requires copying the icon SVG files into the repo since they're not included in npm. It was simpler to render transparent for these, since the function was only being used for breadcrumbs and the Web Console doesn't use Blueprint's breadcrumbs (AFAIK)
  • Upgrade Blueprint to pull in these changes that make its scss source compatible with Dart Sass

I also ran sass-migrator to clean up deprecated syntax in our local scss files.


This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you so much for doing this. Everyone out there developing Druid on an M1 Mac salutes you.

(sent from my Intel based mac)

@vogievetsky vogievetsky merged commit 38adac4 into apache:master Mar 16, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants