Fix triple protocol for native image #15115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JermaineHua <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15115 +/- ##
=========================================
Coverage 60.71% 60.72%
- Complexity 10879 10906 +27
=========================================
Files 1884 1885 +1
Lines 86050 86060 +10
Branches 12893 12893
=========================================
+ Hits 52249 52257 +8
- Misses 28347 28352 +5
+ Partials 5454 5451 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlbumenJ
requested changes
Feb 10, 2025
| @@ -176,7 +176,7 @@ public static RemoteMetadataService referMetadataService(ServiceInstance instanc | |||
| RemoteMetadataService remoteMetadataService; | |||
| ProxyFactory proxyFactory = | |||
| applicationModel.getExtensionLoader(ProxyFactory.class).getAdaptiveExtension(); | |||
| if (useV2) { | |||
| if (useV2 && !inNativeImage) { | |||
There was a problem hiding this comment.
Why can't use v2 in native image here?
There was a problem hiding this comment.
MetadataServiceV2 only supports nativestub proxy mode. This needs to be supported separately, and the original problem should be fixed first in this pr.
|
|
|
It doesn't seem to be about the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Checklist