add functionality of search view close using back button #160
Conversation
| private void assignBaseFragment(FineractBaseFragment baseFragment) { | ||
| this.baseFragment = baseFragment; | ||
| } | ||
|
|
There was a problem hiding this comment.
@EGOR-IND this looks very lengthy code. There is one solution if you want to try. Searchview assigned in every fragment is correct but instead of assigning Basefragments use onPause() in every fragment and in onPause method type searchview.OnActionViewCollapsed() it will make you work done with less code. For more reference follow this pr made for similar issue.
| private void assignBaseFragment(FineractBaseFragment baseFragment) { | |
| this.baseFragment = baseFragment; | |
| } |
There was a problem hiding this comment.
Now here is the problem because my is actually a little bit shorter than appying on pause every fragment and also I think using interface is little better in software development sense because it keeps coupling low in a broad view.
There was a problem hiding this comment.
If you find it appropriate then it ok. 👍
Fixes FINCN-284
WhatsApp.Video.2021-03-18.at.23.16.04.mp4
Added functionality of closing search view from back button in every activity with search view.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.