FINERACT-2156: Confirm existance of elements before accessing them #4202
Conversation
hs_err_pid7500.log
Outdated
| @@ -0,0 +1,1068 @@ | |||
| # | |||
hs_err_pid8972.log
Outdated
| @@ -0,0 +1,1093 @@ | |||
| # | |||
wkigenyi
force-pushed
the
2156
branch
2 times, most recently
from
d1052ab to
07b94e7
Compare
|
@adamsaghy this is now ready for review |
| @@ -1594,12 +1594,19 @@ public void validateAccountBalanceDoesNotBecomeNegative(final String transaction | |||
| public void validateAccountBalanceDoesNotViolateOverdraft(final List<SavingsAccountTransaction> savingsAccountTransaction, | |||
| final BigDecimal amountPaid) { | |||
| if (savingsAccountTransaction != null) { | |||
| SavingsAccountTransaction savingsAccountTransactionFirst = savingsAccountTransaction.get(0); | |||
There was a problem hiding this comment.
Would you mind to simplify the logic a little bit further?
You can merge the savingsAccountTransaction != null and savingsAccountTransaction.size() > 0 condition together and if they are TRUE take the running balance of the first element otherwise it is BigDecimal.ZERO (if there are no any transaction the running balance must be 0).
After you can deduct the amountPaid from the above balance and if the balance is negative and allowOverdraft is FALSE then InsufficientAccountBalanceException to be thrown.
I believe it would be easier to read and cover better the requirements!
Also kindly asking you to write a test (it can be unit tests), which covers the following situations:
savingsAccountTransactionis empty andamountPaidis positive andallowOverdraft = true-> No exception!savingsAccountTransactionis empty andamountPaidis positive andallowOverdraft = false-> Exception to be thrown!savingsAccountTransactionis not empty andamountPaidis positive andamountPaidis higher than the running balance of the 1st transaciton andallowOverdraft = true-> No exception!savingsAccountTransactionis not empty andamountPaidis positive andamountPaidis lower than the running balance of the 1st transaction andallowOverdraft = false-> Exception to be thrown!savingsAccountTransactionis not empty andamountPaidis positive andamountPaidis equal with the running balance of the 1st transaction andallowOverdraft = false-> No exception!
There was a problem hiding this comment.
@wkigenyi Are you still working on the ticket?
There was a problem hiding this comment.
@adamsaghy should the case in bullet 4 throw an exception ? amountPaid is LOWER than the runningBalance. In this case I think the exception should not be thrown
There was a problem hiding this comment.
Yes, the bullet 3 and 4 might be should do the opposite!
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
@wkigenyi any plans to continue this PR? |
|
Yes I work on it. Been busy with some back log. |
|
Hello Victor,
I will make effort to close it within the week.
Regards.
Wilfred
…On Mon, Mar 3, 2025 at 6:32 AM Víctor Romero ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
<#4202 (comment)>:
> @@ -1594,12 +1594,19 @@ public void validateAccountBalanceDoesNotBecomeNegative(final String transaction
public void validateAccountBalanceDoesNotViolateOverdraft(final List<SavingsAccountTransaction> savingsAccountTransaction,
final BigDecimal amountPaid) {
if (savingsAccountTransaction != null) {
- SavingsAccountTransaction savingsAccountTransactionFirst = savingsAccountTransaction.get(0);
@wkigenyi <https://github.com/wkigenyi> Are you still working on the
ticket?
—
Reply to this email directly, view it on GitHub
<#4202 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEK6IQ7NAS5GE6GD2VGNAX32SPELLAVCNFSM6AAAAABS2DOJRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNJSHE4DONBZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
wkigenyi
force-pushed
the
2156
branch
3 times, most recently
from
2589c4d to
25a5d52
Compare
|
@adamsaghy could you guide me on how to fix this test? The result says it got status 403 instead of the 400 that was expected. In the test I specified: I am not sure that status code is being considered instead of the string I specified. |
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.