FINERACT-2181: Rework "createMissingAccrualTransactionDuringChargeOffIfNeeded" to avoid flushing and triggering business event as part of Transaction processor #4446
+271
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IfNeeded" to avoid flushing and triggering business event as part of Transaction processor
adamsaghy
reviewed
Mar 10, 2025
| transactionChanges.add(new TransactionChangeData(oldTransaction, newTransaction)); | ||
| } | ||
|
|
||
| public void addTransactionChange(final TransactionChangeData transactionChangeData) { |
There was a problem hiding this comment.
addReversedTransaction and addTransactionChange is pretty much the same... should we rather use just 1 method and as parameter we can provide the old and new? (including if any of them is null?)
adamsaghy
reviewed
Mar 10, 2025
| final ChangedTransactionDetail changedTransactionDetail = loan.getTransactionProcessor().processLatestTransaction(loanTransaction, | ||
| new TransactionCtx(loan.getCurrency(), loan.getRepaymentScheduleInstallments(), loan.getActiveCharges(), | ||
| new MoneyHolder(loan.getTotalOverpaidAsMoney()), new ChangedTransactionDetail())); | ||
| if (!loan.isInterestRecalculationEnabled()) { |
There was a problem hiding this comment.
why to filter for disabled interest recalculation?
adamsaghy
reviewed
Mar 10, 2025
| for (final Map.Entry<Long, LoanTransaction> mapEntry : changedTransactionDetail.getNewTransactionMappings().entrySet()) { | ||
| loanAccountService.saveLoanTransactionWithDataIntegrityViolationChecks(mapEntry.getValue()); | ||
| loanAccountTransfersService.updateLoanTransaction(mapEntry.getKey(), mapEntry.getValue()); | ||
| final List<TransactionChangeData> sortedChanges = changedTransactionDetail.getTransactionChanges().stream() |
There was a problem hiding this comment.
Why to sort them again? the list should contain in the right order the created / reversed / reverse-replayed transactions.
adamsaghy
reviewed
Mar 10, 2025
| @@ -1375,6 +1385,9 @@ private void handleChargeOff(final LoanTransaction loanTransaction, final Transa | |||
| if (transactionCtx instanceof ProgressiveTransactionCtx progressiveTransactionCtx) { | |||
| progressiveTransactionCtx.setChargedOff(true); | |||
| } | |||
| if (!loanTransaction.getLoan().isInterestRecalculationEnabled()) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework "createMissingAccrualTransactionDuringChargeOffIfNeeded" to avoid flushing and triggering business event as part of Transaction processor.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.