[FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler #25504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @1996fanrui Could you help take a look ? many thx~ |
...a/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java
Outdated
Show resolved
Hide resolved
...a/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java
Show resolved
Hide resolved
RocMarshal
force-pushed
the
FLINK-33389
branch
from
55d4eba to
46bbf39
Compare
RocMarshal
force-pushed
the
FLINK-33389
branch
from
46bbf39 to
3040c70
Compare
RocMarshal
force-pushed
the
FLINK-33389
branch
3 times, most recently
from
94f7d10 to
ac63a9c
Compare
|
Hi, @1996fanrui @huyuanfeng2018 Could you help take a look if you had the free time ? Many thanks ! |
huyuanfeng2018
approved these changes
Nov 19, 2024
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractSlotSharingStrategy.java
Show resolved
Hide resolved
huyuanfeng2018
approved these changes
Nov 19, 2024
RocMarshal
force-pushed
the
FLINK-33389
branch
from
62f9c98 to
f8e434d
Compare
1996fanrui
reviewed
Dec 2, 2024
| import static org.apache.flink.util.Preconditions.checkNotNull; | ||
|
|
||
| /** Execute slot sharing groups builder based on the balanced scheduling strategy. */ | ||
| public class TaskBalancedExecutionSlotSharingGroupBuilder { |
There was a problem hiding this comment.
May I know is this class copied from TaskBalancedPreferredSlotSharingStrategy?
It's better to be done in a separate refactor commit.
Also, please help double check whether other code is refactor as well.
There was a problem hiding this comment.
Good proposal 👍 and many thanks ! Updated~
RocMarshal
force-pushed
the
FLINK-33389
branch
2 times, most recently
from
4a93f4e to
0a8bbd7
Compare
…lder as a separated class.
…as SlotSharingStrategy then refactor the implementation of the default strategy.
…d abstractions of adaptive scheduler.
…m concrete slot assigners up to SlotSharingSlotAllocator.
…ple the logic of slot state localization priority allocation and stateless allocation.
RocMarshal
force-pushed
the
FLINK-33389
branch
from
2b20da4 to
0220da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler
Brief change log
SlotSharingStrategyand related implementations for the original slot sharing strategy and tasks balanced slot sharing strategy.CoLocationGrouprelated methods forJobInformation,VertexInformationVerifying this change
This change is already covered by existing tests,
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation