Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-33390][runtime] Support slot balancing at TM level for Adaptive Scheduler #25510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-33390][runtime] Support slot balancing at TM level for Adaptive Scheduler #25510

wants to merge 1 commit into from

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

[FLINK-33390][runtime] Support slot balancing at TM level for Adaptive Scheduler

  • Introduce SlotsBalancedRequestSlotMatchingStrategy for the slots balancing.
  • introduce SimpleRequestSlotMatchingStrategy for the raw feature.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

  • AbstractRequestSlotMatchingStrategyTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

eskabetxe
eskabetxe approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@eskabetxe eskabetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RocMarshal
Copy link
Contributor Author

Hi, @XComp Could you help take a look if you had the free time ?
Thank you very much~ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskabetxe eskabetxe eskabetxe approved these changes

Assignees
No one assigned
Labels
component=Runtime/Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RocMarshal @flinkbot @eskabetxe