Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-36485 remove deprecated method fromDataStream #25523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbalchan
Copy link
Contributor

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36485 Remove deprecated method StreamTableEnvironment fromDataStream

Brief change log

Removed deprecated method

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 15, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xuyangzhong
Copy link
Contributor

Hi, @jbalchan can you take a look at the ci failure?

@jbalchan jbalchan force-pushed the FLINK-36485-remove-deprecated-method-StreamTableEnvironment-fromDataStream branch from 8ee5111 to 8daef08 Compare January 2, 2025 17:16
@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 2, 2025

@flinkbot run azure

@xuyangzhong
Copy link
Contributor

@jbalchan The ci failed when compiling, could you please resolve it again?

@jbalchan jbalchan force-pushed the FLINK-36485-remove-deprecated-method-StreamTableEnvironment-fromDataStream branch from 8daef08 to e321e66 Compare January 9, 2025 13:33
@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 9, 2025

@flinkbot run azure

@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 9, 2025

@flinkbot run azure

1 similar comment
@xishuaidelin
Copy link
Contributor

@flinkbot run azure

@snuyanzin
Copy link
Contributor

@jbalchan , @xishuaidelin it is impossible to make a compilation error resolved with rerunning the ci
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=65099&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=7894

as it is mentioned in logs

09:53:18.506 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project flink-table-api-java-bridge: Compilation failure
09:53:18.506 [ERROR] /__w/3/s/flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImpl.java:[308,5] method does not override or implement a method from a supertype
09:53:18.506 [ERROR] 

the code should be adapted to be compilable and to pass tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants