Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36487] Remove deprecated method createTemporaryView StreamTableE… #25524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbalchan
Copy link
Contributor

…nvironment

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36487 Remove deprecated method StreamTableEnvironment createTemporaryView

Brief change log

Removed deprecated method

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 15, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that this method is referred to in the docs. Here is an example
createTemporaryView
. I suggest replacing this example in the docs with one using the non-deprecated API.
Also the Python code calls this deprecated method - so we should remove that also.

I have updated the umbrella issue, : https://issues.apache.org/jira/projects/FLINK/issues/FLINK-36476 with the question if the Python API is not marked deprecated but the java API is deprecated - can we remove both - or isn't this against the deprecation rules.

@jbalchan jbalchan force-pushed the FLINK-36487-remove-deprecated-method-StreamTableEnvironment-createTemporaryView branch from c64623f to 38a4d5b Compare October 16, 2024 13:13
@jbalchan
Copy link
Contributor Author

@flinkbot run azure

@jbalchan jbalchan changed the title FLINK-36487 remove deprecated method createTemporaryView StreamTableE… [FLINK-36487] Remove deprecated method createTemporaryView StreamTableE… Oct 17, 2024
@xuyangzhong
Copy link
Contributor

Hi, @jbalchan the ci seems failed, can you take a look?

@xuyangzhong
Copy link
Contributor

@jbalchan any update? The code freeze date for flink 2.0.0 is approaching...

@jbalchan jbalchan force-pushed the FLINK-36487-remove-deprecated-method-StreamTableEnvironment-createTemporaryView branch from 38a4d5b to 37f94b5 Compare January 9, 2025 13:44
@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 9, 2025

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants