FLINK-36505 remove deprecated methods TableFunction #25538
+0
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
tinaselenge
reviewed
Oct 23, 2024
| public TypeInformation<Row> getResultType() { | ||
| return new RowTypeInfo(config.getSelectedFieldTypes(), config.getSelectedFieldNames()); | ||
| } | ||
|
|
||
| @Override | ||
| public void open(FunctionContext context) throws Exception { | ||
| super.open(context); |
There was a problem hiding this comment.
TypeInformation<Row> rowType = getResultType();
this seems to be calling the removed function?
superdiaodiao
suggested changes
Nov 18, 2024
There was a problem hiding this comment.
In the Azure compile log, it indicates that:
14:00:11.430 [ERROR] /__w/3/s/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java:[186,60] cannot find symbol
14:00:11.430 [ERROR] symbol: method getResultType()
14:00:11.430 [ERROR] location: variable tableFunction of type org.apache.flink.table.functions.TableFunction<T>
So you also have to check here.
|
Hi, @jbalchan is there any progress on the ci failure? |
|
Re-Checking now. Will update by End of today. |
jbalchan
force-pushed
the
FLINK-36505-remove-deprecated-methods-TableFunction
branch
from
eb12f82 to
772769a
Compare
jbalchan
force-pushed
the
FLINK-36505-remove-deprecated-methods-TableFunction
branch
2 times, most recently
from
0222d40 to
0824c9e
Compare
jbalchan
force-pushed
the
FLINK-36505-remove-deprecated-methods-TableFunction
branch
from
0824c9e to
c707158
Compare
|
@flinkbot run azure |
|
@jbalchan the ci failed again where compiling, can you take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-36505] https://issues.apache.org/jira/browse/FLINK-36505 Removed all deprecated methods - getResultType and getParameterTypes from TableFunction under table-common.
Brief change log
Removed all deprecated methods - getResultType and getParameterTypes from TableFunction under table-common.
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation