Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-36479 remove deprecated method Table getSchema as #25540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jbalchan
Copy link
Contributor

What is the purpose of the change

[FLINK-36479] (https://issues.apache.org/jira/browse/FLINK-36479)
Component: Table SQL / API

Remove deprecated methods Table getSchema and as

Brief change log

Remove deprecated methods Table getSchema and as

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 16, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

/**
* Renames the fields of the expression result. Use this to disambiguate fields before joining
* to operations.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a test that uses this function in Scala in OverWindowValidationTest is has .
Over.partitionBy($"c").orderBy($"rowtime").preceding(2).following($"xx").as($"w"))

@xuyangzhong
Copy link
Contributor

Hi, @jbalchan can you take a look at the ci failure?

@jbalchan jbalchan force-pushed the FLINK-36479-remove-deprecated-method-Table-getSchema-as branch from 1355727 to e0aa873 Compare January 2, 2025 16:21
@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 2, 2025

@flinkbot run azure

@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 2, 2025

@flinkbot run azure

@xuyangzhong
Copy link
Contributor

Hi, @jbalchan any update? If you're busy, I'll take charge of this task and add you as co-author since the code freeze date for flink 2.0.0 is approaching...

@jbalchan
Copy link
Contributor Author

jbalchan commented Jan 9, 2025

Hi @xuyangzhong, I'm struggling to fix the scala test cases for this. I'm stuck on it and might need more time.
Since code freeze is approaching, please take over this.
I'm sooo sorry I couldn't figure out how to fix it...

@xuyangzhong
Copy link
Contributor

No worries, I'll continue handling it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants